Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeviceSanitizer] Support "-fsanitize-ignorelist=" to disable sanitizing on some of kernels #15294

Open
wants to merge 36 commits into
base: sycl
Choose a base branch
from
Open

[DeviceSanitizer] Support "-fsanitize-ignorelist=" to disable sanitizing on some of kernels #15294

wants to merge 36 commits into from

Conversation

AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Sep 5, 2024 •
edited
Loading

UR: oneapi-src/unified-runtime#2055

We reuse -fsanitize-ignorelist= to support kernel filtering.

Usage: https://clang.llvm.org/docs/SanitizerSpecialCaseList.html

@AllanZyne AllanZyne mentioned this pull request Sep 5, 2024
Open
@AllanZyne
Copy link
Contributor Author

Hi @intel/dpcpp-sanitizers-review @intel/dpcpp-tools-reviewers @intel/dpcpp-esimd-reviewers, please review, Thanks!

sarnex
sarnex reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not qualified to review the actual devicesan stuff, some high level comments

clang/lib/Driver/OffloadBundler.cpp Show resolved Hide resolved
llvm/include/llvm/SYCLLowerIR/AsanKernelMetadata.h Outdated Show resolved Hide resolved
llvm/include/llvm/SYCLLowerIR/AsanKernelMetadata.h Show resolved Hide resolved
llvm/lib/SYCLLowerIR/SanitizeDeviceGlobal.cpp Show resolved Hide resolved
libdevice/sanitizer_utils.cpp Outdated Show resolved Hide resolved
sycl/test-e2e/AddressSanitizer/common/kernel-filter.cpp Outdated Show resolved Hide resolved
@AllanZyne AllanZyne requested a review from a team as a code owner November 8, 2024 02:58
sarnex
sarnex approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as my comments are addressed, but i will leave it to others to review the technical part of the change

zhaomaosu
zhaomaosu reviewed Nov 14, 2024
View reviewed changes
llvm/lib/SYCLLowerIR/AsanKernelMetadata.cpp
SmallVector<Metadata *, 3> MD;
auto *Ty = Type::getInt32Ty(Ctx);
MD.push_back(ConstantAsMetadata::get(
Constant::getIntegerValue(Ty, APInt(32, SPIRV_HOST_ACCESS_DECOR))));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

host access mode should be read only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaomaosu zhaomaosu zhaomaosu left review comments

@sarnex sarnex sarnex approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AllanZyne @sarnex @zhaomaosu